css: Add "border-spacing" CSS property
authorBenjamin Otte <otte@redhat.com>
Sat, 10 Dec 2016 02:26:24 +0000 (03:26 +0100)
committerBenjamin Otte <otte@redhat.com>
Sat, 10 Dec 2016 03:32:55 +0000 (04:32 +0100)
It's using a GtkCssPositionValue, even though that name is wrong. But
the functionality of managing 2 lengths is exactly what we want.

Nobody is using this yet.

gtk/gtkcsspositionvalue.c
gtk/gtkcsspositionvalueprivate.h
gtk/gtkcssstylepropertyimpl.c
gtk/gtkcsstypesprivate.h

index 9102b16bb083e44e469268be556fcb21c1cc1c88..62ecc68b57621912c4bb5296d8dd4fc68bd685da 100644 (file)
@@ -291,6 +291,32 @@ _gtk_css_position_value_try_parse (GtkCssParser *parser)
   return position_value_parse (parser, TRUE);
 }
 
+GtkCssValue *
+gtk_css_position_value_parse_spacing (GtkCssParser *parser)
+{
+  GtkCssValue *x, *y;
+
+  x = _gtk_css_number_value_parse (parser, GTK_CSS_PARSE_LENGTH | GTK_CSS_POSITIVE_ONLY);
+  if (x == NULL)
+    return NULL;
+
+  if (gtk_css_number_value_can_parse (parser))
+    {
+      y = _gtk_css_number_value_parse (parser, GTK_CSS_PARSE_LENGTH | GTK_CSS_POSITIVE_ONLY);
+      if (y == NULL)
+        {
+          _gtk_css_value_unref (x);
+          return NULL;
+        }
+    }
+  else
+    {
+      y = _gtk_css_value_ref (x);
+    }
+
+  return _gtk_css_position_value_new (x, y);
+}
+
 double
 _gtk_css_position_value_get_x (const GtkCssValue *position,
                                double             one_hundred_percent)
index d1d113bb13b8afcfd4e7f79c6d1643ae94a7ae47..fc87fbcbce481de0a25428ff8b2d12612bcdde24 100644 (file)
@@ -29,11 +29,12 @@ GtkCssValue *   _gtk_css_position_value_new           (GtkCssValue            *x
                                                        GtkCssValue            *y);
 GtkCssValue *   _gtk_css_position_value_parse         (GtkCssParser           *parser);
 GtkCssValue *   _gtk_css_position_value_try_parse     (GtkCssParser           *parser);
+GtkCssValue *   gtk_css_position_value_parse_spacing  (GtkCssParser           *parser);
 
 double          _gtk_css_position_value_get_x         (const GtkCssValue      *position,
-                                                     double                  one_hundred_percent);
+                                                       double                  one_hundred_percent);
 double          _gtk_css_position_value_get_y         (const GtkCssValue      *position,
-                                                     double                  one_hundred_percent);
+                                                       double                  one_hundred_percent);
 
 
 G_END_DECLS
index 3571d68dfd3ec28a3e8f89156fd6743c8030dd00..d781d512514f305b37bec55d8d61d602ee642b3f 100644 (file)
@@ -562,6 +562,13 @@ transform_value_parse (GtkCssStyleProperty *property,
   return _gtk_css_transform_value_parse (parser);
 }
 
+static GtkCssValue *
+border_spacing_value_parse (GtkCssStyleProperty *property,
+                            GtkCssParser        *parser)
+{
+  return gtk_css_position_value_parse_spacing (parser);
+}
+
 static GtkCssValue *
 border_corner_radius_value_parse (GtkCssStyleProperty *property,
                                   GtkCssParser        *parser)
@@ -1448,6 +1455,16 @@ _gtk_css_style_property_init_properties (void)
                                           NULL,
                                           _gtk_css_transform_value_new_none ());
 
+  gtk_css_style_property_register        ("border-spacing",
+                                          GTK_CSS_PROPERTY_BORDER_SPACING,
+                                          G_TYPE_NONE,
+                                          GTK_STYLE_PROPERTY_ANIMATED,
+                                          GTK_CSS_AFFECTS_SIZE,
+                                          border_spacing_value_parse,
+                                          NULL,
+                                          _gtk_css_position_value_new (_gtk_css_number_value_new (0, GTK_CSS_PX),
+                                                                       _gtk_css_number_value_new (0, GTK_CSS_PX)));
+
   gtk_css_style_property_register        ("min-width",
                                           GTK_CSS_PROPERTY_MIN_WIDTH,
                                           G_TYPE_INT,
index bcc1dc04ff3fdf40067c957d6e15f46b03f7633e..644f0079b73feb6f06d18cd48012093016c4adb6 100644 (file)
@@ -207,6 +207,7 @@ enum { /*< skip >*/
   GTK_CSS_PROPERTY_ICON_SHADOW,
   GTK_CSS_PROPERTY_ICON_STYLE,
   GTK_CSS_PROPERTY_ICON_TRANSFORM,
+  GTK_CSS_PROPERTY_BORDER_SPACING,
   GTK_CSS_PROPERTY_MIN_WIDTH,
   GTK_CSS_PROPERTY_MIN_HEIGHT,
   GTK_CSS_PROPERTY_TRANSITION_PROPERTY,